mirror of https://github.com/pulumi/pulumi.git
c496921d44
Issue #10659 lists a number of extra linting checks that we could enable in order to make our Go code more robust. This commit implements as many as seem sensible: * `durationcheck`, which checks for multiplication of `time.Duration`s, which can lead to unexpected behaviour (e.g. `time.Second * time.Second` is *not* one second) * `goprintffuncname`, which checks that `Printf`-like functions are appropriately suffixed with `f` to indicate as such * `tenv`, which checks for `os.Setenv` in tests where `t.Setenv` is generally a better solution * `wastedassign`, which checks for assignments whose values are never used (such as initial values before an `if` where both branches then overwrite the value) * `whitespace`, which checks for blank lines at the beginning and end of blocks such as functions, `if`s, `for`s and so on. This commit does *not* enable the following checks listed in #10659: * `wrapcheck`, which insists that third-party library errors are always `%w`rapped -- we have a lot of cases where we don't do this and it's probably a bit more involved than "just wrap them" in terms of making sure we don't break anything (maybe) * `predeclared`, which checks for shadowing of existing Go identifiers -- we use `old` and `new` a lot, especially in step generation, so this is probably a slightly bigger clean-up/one we might want to opt out of * `mnd` (magic number detection) -- we have a lot of failures on this * `nilnil` -- we only have a couple of failures on this; these could probably be handled with `//nolint` but for now I've opted not to take this route. |
||
---|---|---|
.. | ||
README.md | ||
bind.go | ||
docs_parser.go | ||
docs_renderer.go | ||
docs_test.go | ||
loader.go | ||
loader_cached.go | ||
loader_cached_test.go | ||
loader_client.go | ||
loader_js.go | ||
loader_mmap.go | ||
loader_schema_test.go | ||
loader_server.go | ||
loader_test.go | ||
mock_pulumi_schema.go | ||
package_reference.go | ||
pulumi.json | ||
schema.go | ||
schema_test.go |
README.md
(schema)=
Pulumi Schema
This package defines Pulumi Schema, a language-neutral specification for cloud resource models. Pulumi Schema is the interface definition language for all Pulumi Packages, and is used as the input to SDK code generation for each supported Pulumi language.