mirror of https://github.com/pulumi/pulumi.git
bb1964f4ec
13120: Make convert more lenient r=Frassle a=Frassle <!--- Thanks so much for your contribution! If this is your first time contributing, please ensure that you have read the [CONTRIBUTING](https://github.com/pulumi/pulumi/blob/master/CONTRIBUTING.md) documentation. --> # Description <!--- Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. --> Fixes https://github.com/pulumi/pulumi/issues/13117 This adds a new "--strict" flag to `pulumi convert` which defaults to false. When strict is NOT set we bind the PCL with the extra options of `SkipResourceTypechecking`, `AllowMissingVariables`, and `AllowMissingProperties`. This will change some errors to warnings in code generation. The `strict` flag is sent over the gRPC interface to the Go/Node plugins for their `GenerateProject` methods as they have to do PCL binding plugin side currently. ## Checklist - [x] I have run `make tidy` to update any new dependencies - [x] I have run `make lint` to verify my code passes the lint check - [ ] I have formatted my code using `gofumpt` <!--- Please provide details if the checkbox below is to be left unchecked. --> - [x] I have added tests that prove my fix is effective or that my feature works <!--- User-facing changes require a CHANGELOG entry. --> - [x] I have run `make changelog` and committed the `changelog/pending/<file>` documenting my change <!-- If the change(s) in this PR is a modification of an existing call to the Pulumi Cloud, then the service should honor older versions of the CLI where this change would not exist. You must then bump the API version in /pkg/backend/httpstate/client/api.go, as well as add it to the service. --> - [ ] Yes, there are changes in this PR that warrants bumping the Pulumi Cloud API version <!-- `@Pulumi` employees: If yes, you must submit corresponding changes in the service repo. --> Co-authored-by: Fraser Waters <fraser@pulumi.com> |
||
|---|---|---|
| .. | ||
| 20230315--engine--deletedwith-resourceoption-is-now-inherited-from-its-parent-across-sdks.yaml | ||
| 20230523--engine--add-pulumi-tags-config-option-to-set-stack-tags.yaml | ||
| 20230526--programgen-go--fix-conversion-of-programs-with-components-for-go.yaml | ||
| 20230602--cli-plugin--language-plugins-respect-pulumi_ignore_ambient_plugins.yaml | ||
| 20230602--programgen-dotnet-go--do-not-error-out-when-generaing-not-yet-implemented-forexpressions.yaml | ||
| 20230602--programgen-go-nodejs--fix-a-panic-in-diagnostics-from-go-nodejs-project-generation.yaml | ||
| 20230602--programgen-nodejs--only-await-promise-returning-invokes-in-typescript-program-gen.yaml | ||
| 20230603--programgen-dotnet--only-await-task-returning-invokes-in-dotnet-program-gen.yaml | ||
| 20230607--cli--convert-now-defaults-to-be-more-leniant-about-program-correctness-old-behaviour-can-be-toggled-back-on-with-strict.yaml | ||
| 20230607--cli-new--escape-special-characters-in-project-description.yaml | ||
| 20230607--pkg--upgrade-pulumi-java-to-v0-9-4.yaml | ||
| 20230607--programgen-go--fix-panic-in-go-program-gen-when-encountering-splat-expressions.yaml | ||
| 20230607--programgen-nodejs--allow-output-variables-to-have-the-same-identifier-as-other-program-nodes.yaml | ||