mirror of https://github.com/pulumi/pulumi.git
959fc6c8b4
<!--- Thanks so much for your contribution! If this is your first time contributing, please ensure that you have read the [CONTRIBUTING](https://github.com/pulumi/pulumi/blob/master/CONTRIBUTING.md) documentation. --> # Description <!--- Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. --> Combining #15120 and #15124 and including fixes to allow tests to pass. Enable race detection in the binary we're using for integration tests. This will allow us to catch more data races before they get into any release. This does mean the binary we're using for integration tests is slightly different from the binary we're releasing, however that's already the case as we're running a binary with coverage enabled for them. Later we rebuild the binary we're actually releasing. This requires us to fix the race between snapshot code, display code, and the step executor. I've done that by adding a lock to the State struct. This does not feel great, but it's a quick way to fix this and get race detection running (and unblocks #15871 which was also hitting the race detector because it started pulling snapshot code into unit tests as well). There's probably a more principled overhaul that doesn't require locking at this level. ## Checklist - [x] I have run `make tidy` to update any new dependencies - [x] I have run `make lint` to verify my code passes the lint check - [x] I have formatted my code using `gofumpt` <!--- Please provide details if the checkbox below is to be left unchecked. --> - [x] I have added tests that prove my fix is effective or that my feature works <!--- User-facing changes require a CHANGELOG entry. --> - [x] I have run `make changelog` and committed the `changelog/pending/<file>` documenting my change <!-- If the change(s) in this PR is a modification of an existing call to the Pulumi Cloud, then the service should honor older versions of the CLI where this change would not exist. You must then bump the API version in /pkg/backend/httpstate/client/api.go, as well as add it to the service. --> - [ ] Yes, there are changes in this PR that warrants bumping the Pulumi Cloud API version <!-- @Pulumi employees: If yes, you must submit corresponding changes in the service repo. --> |
||
|---|---|---|
| .. | ||
| ci-build-binaries.yml | ||
| ci-build-sdks.yml | ||
| ci-dev-release.yml | ||
| ci-info.yml | ||
| ci-lint.yml | ||
| ci-prepare-release.yml | ||
| ci-run-test.yml | ||
| ci-test-docs-generation.yml | ||
| ci.yml | ||
| command-dispatch.yml | ||
| cron-direct-build.yml | ||
| download-pulumi-cron.yml | ||
| on-community-pr.yml | ||
| on-merge.yml | ||
| on-pr-changelog.yml | ||
| on-pr-close.yml | ||
| on-pr-default.yml | ||
| on-pr.yml | ||
| on-push.yml | ||
| on-release.yml | ||
| pr-test-acceptance-on-dispatch.yml | ||
| pr-test-codegen-downstream.yml | ||
| pr-test-docs-gen-on-pr.yml | ||
| pr-test-docs-generation-on-dispatch.yml | ||
| rebase.yml | ||
| release-homebrew-tap.yml | ||
| release-pr.yml | ||
| release.pub | ||
| release.yml | ||
| sign.yml | ||
| trigger-homebrew-event.yml | ||
| trigger-release-docs-event.yml | ||