mirror of https://github.com/pulumi/pulumi.git
2fcdaf8445
<!--- Thanks so much for your contribution! If this is your first time contributing, please ensure that you have read the [CONTRIBUTING](https://github.com/pulumi/pulumi/blob/master/CONTRIBUTING.md) documentation. --> # Description Fixes a panic that occurs when attempting to encode certain values, for example a map that contains a nil value: ```go bag := bagtag{ String: "something", StringOpt: "ohmv", MapOpt: map[string]interface{}{ "a": "something", "b": nil, // this reflect.Value is of type Interface and IsNil is true. }, } _ = resource.NewPropertyMap(bag) // panic here ``` New tests are provided to cover the above scenario and to cover each type of value, including nil cases where appropriate. Fixes: https://github.com/pulumi/pulumi-kubernetes/issues/2622 Follow-up to: https://github.com/pulumi/pulumi/pull/9810 ## Checklist - [x] I have run `make tidy` to update any new dependencies - [x] I have run `make lint` to verify my code passes the lint check - [ ] I have formatted my code using `gofumpt` <!--- Please provide details if the checkbox below is to be left unchecked. --> - [x] I have added tests that prove my fix is effective or that my feature works <!--- User-facing changes require a CHANGELOG entry. --> - [x] I have run `make changelog` and committed the `changelog/pending/<file>` documenting my change <!-- If the change(s) in this PR is a modification of an existing call to the Pulumi Cloud, then the service should honor older versions of the CLI where this change would not exist. You must then bump the API version in /pkg/backend/httpstate/client/api.go, as well as add it to the service. --> - [ ] Yes, there are changes in this PR that warrants bumping the Pulumi Cloud API version <!-- @Pulumi employees: If yes, you must submit corresponding changes in the service repo. --> |
||
|---|---|---|
| .. | ||
| 20231103--pkg--fixes-a-panic-in-property-mapping-logic.yaml | ||
| 20231103--sdk-python--add-provider-side-caching-for-dynamic-provider-deserialization.yaml | ||
| 20231103--sdkgen-go--remove-generic-tooutput-methods-from-legacy-non-generic-go-sdks.yaml | ||