pulumi/pkg/engine/lifecycletest
Fraser Waters 1138fdb63c
Upgrade output values in source_eval (#15362)
<!--- 
Thanks so much for your contribution! If this is your first time
contributing, please ensure that you have read the
[CONTRIBUTING](https://github.com/pulumi/pulumi/blob/master/CONTRIBUTING.md)
documentation.
-->

# Description

<!--- Please include a summary of the change and which issue is fixed.
Please also include relevant motivation and context. -->

Stage 1 of updating how we deal with OutputValues in source_eval for
transforms.

This makes two changes that should result in basically a no-op for
standard resources, but update all Computed/Secret values to
OutputValues for Call and Construct.

This is a no-op for standard resources because previously we set
"KeepOutputs" to false when we unmarshalled them. That replaced all
OutputValues with Computed/Secret. Now we do "UpdgradeOutputs" at the
start of source_eval but then call "DowngradeOutputs" before passing the
properties on to the rest of the system. So this is a complete no-op.

But for Call/Construct we used to use "KeepOutputs" but now we do
"UpgradeOutputs". So values that previously got sent as Computed/Secret
will now get sent as OutputValue. This _should_ be fine, all users of
Construct/Call already had to handle OutputValue on their interface, so
this just means a few more cases of seeing those values.


## Checklist

- [x] I have run `make tidy` to update any new dependencies
- [x] I have run `make lint` to verify my code passes the lint check
  - [x] I have formatted my code using `gofumpt`

<!--- Please provide details if the checkbox below is to be left
unchecked. -->
- [x] I have added tests that prove my fix is effective or that my
feature works
<!--- 
User-facing changes require a CHANGELOG entry.
-->
- [x] I have run `make changelog` and committed the
`changelog/pending/<file>` documenting my change
<!--
If the change(s) in this PR is a modification of an existing call to the
Pulumi Cloud,
then the service should honor older versions of the CLI where this
change would not exist.
You must then bump the API version in
/pkg/backend/httpstate/client/api.go, as well as add
it to the service.
-->
- [ ] Yes, there are changes in this PR that warrants bumping the Pulumi
Cloud API version
<!-- @Pulumi employees: If yes, you must submit corresponding changes in
the service repo. -->
2024-02-06 16:46:31 +00:00
..
alias_test.go Test that an empty parent URN in an alias is treated as the default parent (#15232) 2024-01-26 18:29:22 +00:00
analyzer_test.go Update golangci-lint (#14624) 2023-11-21 15:16:13 +00:00
delete_before_replace_test.go Update golangci-lint (#14624) 2023-11-21 15:16:13 +00:00
golang_sdk_test.go Refactor transformation tests and add Go test (#14851) 2023-12-16 14:06:27 +00:00
import_test.go Enable perfsprint linter (#14813) 2023-12-12 12:19:42 +00:00
pending_delete_test.go Update golangci-lint (#14624) 2023-11-21 15:16:13 +00:00
provider_test.go Don't mutate RegisterResourceRequest (#15297) 2024-01-30 16:45:10 +00:00
pulumi_test.go Upgrade output values in source_eval (#15362) 2024-02-06 16:46:31 +00:00
refresh_test.go Update golangci-lint (#14624) 2023-11-21 15:16:13 +00:00
resource_reference_test.go Update golangci-lint (#14624) 2023-11-21 15:16:13 +00:00
source_query_test.go [conformance tests] Fix run root and use program info everywhere (#15191) 2024-01-25 23:28:58 +00:00
step_generator_test.go [test] increase code coverage of `pkg/resource/deploy` (#14771) 2023-12-10 21:29:37 +00:00
target_test.go Fix handling of delete failures for targeted destroys (#14735) 2023-12-05 17:19:10 +00:00
test_plan.go [tests] testBuilder: Use specified package name (#15269) 2024-01-26 16:20:45 +00:00
update_plan_test.go Update golangci-lint (#14624) 2023-11-21 15:16:13 +00:00