mirror of https://github.com/pulumi/pulumi.git
1c4393b30f
<!--- Thanks so much for your contribution! If this is your first time contributing, please ensure that you have read the [CONTRIBUTING](https://github.com/pulumi/pulumi/blob/master/CONTRIBUTING.md) documentation. --> # Description <!--- Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. --> This PR fixes a bug in the dotnet codegen where the wrong "args" class name would be used, in the case that the resource has no constant inputs. This is an edge case because most resources do have at least one such input. For example, a new resource definition in p/k produced this output: ```csharp namespace Pulumi.Kubernetes.Yaml.V2 { public ConfigGroup(string name, Pulumi.Kubernetes.Types.Inputs.Yaml.V2.ConfigGroupArgs? args = null, CustomResourceOptions? options = null) : base("kubernetes:yaml/v2:ConfigGroup", name, args ?? new ConfigGroupArgs(), MakeResourceOptions(options, ""), remote: true) { } } ``` Which doesn't compile because `ConfigGroupArgs` is in a separate namespace. Should be: ```csharp public ConfigGroup(string name, Pulumi.Kubernetes.Types.Inputs.Yaml.V2.ConfigGroupArgs? args = null, CustomResourceOptions? options = null) : base("kubernetes:yaml/v2:ConfigGroup", name, args ?? new Pulumi.Kubernetes.Types.Inputs.Yaml.V2.ConfigGroupArgs(), MakeResourceOptions(options, ""), remote: true) { } ``` [Here's ](https://github.com/pulumi/pulumi/pull/15488/files#diff-18b12fabab20d68398aced2890b1ca3073cc32081bb62a022b77a5090c209e3bR45)where the fix manifests itself in the new test case. ## Testing A new SDK test case was added to cover the whole `kubernetes20` compatibility mode, based on a simplified schema from the pulumi-kubernetes provider. The schema contains a representative set of resources: 1. `kubernetes:core/v1:ConfigMap` - a non-overlay resource representing a Kubernetes kind. 2. `kubernetes:core/v1:ConfigMapList` - a Kubernetes list kind 3. `kubernetes:helm.sh/v3:Release` - a non-overlay, non-Kubernetes resource 4. `kubernetes:yaml:ConfigGroup` - an overlay component resource An important detail is whether a resource has any input properties that have a constant value, such as we see with `kind` and `apiVersion`. The `Release` resource intentionally has no such constant inputs. ## Checklist - [x] I have run `make tidy` to update any new dependencies - [x] I have run `make lint` to verify my code passes the lint check - [x] I have formatted my code using `gofumpt` <!--- Please provide details if the checkbox below is to be left unchecked. --> - [x] I have added tests that prove my fix is effective or that my feature works <!--- User-facing changes require a CHANGELOG entry. --> - [x] I have run `make changelog` and committed the `changelog/pending/<file>` documenting my change <!-- If the change(s) in this PR is a modification of an existing call to the Pulumi Cloud, then the service should honor older versions of the CLI where this change would not exist. You must then bump the API version in /pkg/backend/httpstate/client/api.go, as well as add it to the service. --> - [ ] Yes, there are changes in this PR that warrants bumping the Pulumi Cloud API version <!-- @Pulumi employees: If yes, you must submit corresponding changes in the service repo. --> |
||
|---|---|---|
| .. | ||
| gen_program_test | ||
| doc.go | ||
| doc_test.go | ||
| gen.go | ||
| gen_intrinsics.go | ||
| gen_program.go | ||
| gen_program_expressions.go | ||
| gen_program_test.go | ||
| gen_test.go | ||
| git_ignore.go | ||
| importer.go | ||
| templates.go | ||
| test.go | ||
| utilities.go | ||
| utilities_test.go | ||