mirror of https://github.com/pulumi/pulumi.git
487 lines
15 KiB
Go
487 lines
15 KiB
Go
package lifecycletest
|
|
|
|
import (
|
|
"errors"
|
|
"testing"
|
|
|
|
"github.com/blang/semver"
|
|
"github.com/stretchr/testify/assert"
|
|
|
|
. "github.com/pulumi/pulumi/pkg/v3/engine" //nolint:revive
|
|
"github.com/pulumi/pulumi/pkg/v3/resource/deploy/deploytest"
|
|
"github.com/pulumi/pulumi/sdk/v3/go/common/resource"
|
|
"github.com/pulumi/pulumi/sdk/v3/go/common/resource/plugin"
|
|
)
|
|
|
|
// Tests that a delete-before-replace operation:
|
|
//
|
|
// * that is interrupted after the deletion (e.g. with a failed create)
|
|
// * and then resumed, with the same original program
|
|
//
|
|
// will:
|
|
//
|
|
// * not call delete (again) on the old resource
|
|
// * remove the PendingReplacement flag from the resource in state
|
|
// * call create on the new resource
|
|
// * remove the old resource from the state
|
|
func TestPendingReplaceResumeWithSameGoals(t *testing.T) {
|
|
t.Parallel()
|
|
|
|
// Arrange.
|
|
p := &TestPlan{}
|
|
project := p.GetProject()
|
|
|
|
returnReplaceDiff := func(
|
|
urn resource.URN,
|
|
id resource.ID,
|
|
oldInputs, oldOutputs, newInputs resource.PropertyMap,
|
|
ignoreChanges []string,
|
|
) (plugin.DiffResult, error) {
|
|
if urn.Name() == "resA" {
|
|
return plugin.DiffResult{
|
|
Changes: plugin.DiffSome,
|
|
ReplaceKeys: []resource.PropertyKey{"key"},
|
|
DeleteBeforeReplace: true,
|
|
}, nil
|
|
}
|
|
|
|
return plugin.DiffResult{}, nil
|
|
}
|
|
|
|
deleteCalled := false
|
|
trackedDelete := func(
|
|
urn resource.URN,
|
|
id resource.ID,
|
|
oldInputs, oldOutputs resource.PropertyMap,
|
|
timeout float64,
|
|
) (resource.Status, error) {
|
|
deleteCalled = true
|
|
return resource.StatusOK, nil
|
|
}
|
|
|
|
createCalled := false
|
|
throwingCreate := func(
|
|
urn resource.URN,
|
|
news resource.PropertyMap,
|
|
timeout float64,
|
|
preview bool,
|
|
) (resource.ID, resource.PropertyMap, resource.Status, error) {
|
|
createCalled = true
|
|
return "", news, resource.StatusUnknown, errors.New("interrupt replace")
|
|
}
|
|
|
|
trackedCreate := func(
|
|
urn resource.URN,
|
|
news resource.PropertyMap,
|
|
timeout float64,
|
|
preview bool,
|
|
) (resource.ID, resource.PropertyMap, resource.Status, error) {
|
|
createCalled = true
|
|
return "created-id", news, resource.StatusOK, nil
|
|
}
|
|
|
|
// Act.
|
|
|
|
// Operation 1 -- initialise the state with a resource.
|
|
upLoaders := []*deploytest.ProviderLoader{
|
|
deploytest.NewProviderLoader("pkgA", semver.MustParse("1.0.0"), func() (plugin.Provider, error) {
|
|
return &deploytest.Provider{}, nil
|
|
}),
|
|
}
|
|
|
|
programF := deploytest.NewLanguageRuntimeF(func(_ plugin.RunInfo, monitor *deploytest.ResourceMonitor) error {
|
|
_, err := monitor.RegisterResource("pkgA:m:typA", "resA", true)
|
|
assert.NoError(t, err)
|
|
|
|
return nil
|
|
})
|
|
|
|
upHostF := deploytest.NewPluginHostF(nil, nil, programF, upLoaders...)
|
|
upOptions := TestUpdateOptions{T: t, HostF: upHostF}
|
|
|
|
upSnap, err := TestOp(Update).
|
|
RunStep(project, p.GetTarget(t, nil), upOptions, false, p.BackendClient, nil, "0")
|
|
assert.NoError(t, err)
|
|
|
|
assert.Len(t, upSnap.Resources, 2)
|
|
assert.Equal(t, upSnap.Resources[0].URN.Name(), "default")
|
|
assert.Equal(t, upSnap.Resources[1].URN.Name(), "resA")
|
|
|
|
// Operation 2 -- return a replacing diff and interrupt it with a failing
|
|
// create.
|
|
replaceLoaders := []*deploytest.ProviderLoader{
|
|
deploytest.NewProviderLoader("pkgA", semver.MustParse("1.0.0"), func() (plugin.Provider, error) {
|
|
return &deploytest.Provider{
|
|
DiffF: returnReplaceDiff,
|
|
DeleteF: trackedDelete,
|
|
CreateF: throwingCreate,
|
|
}, nil
|
|
}),
|
|
}
|
|
|
|
replaceHostF := deploytest.NewPluginHostF(nil, nil, programF, replaceLoaders...)
|
|
replaceOptions := TestUpdateOptions{T: t, HostF: replaceHostF}
|
|
|
|
replaceSnap, err := TestOp(Update).
|
|
RunStep(project, p.GetTarget(t, upSnap), replaceOptions, false, p.BackendClient, nil, "1")
|
|
assert.ErrorContains(t, err, "interrupt replace")
|
|
|
|
assert.Len(t, replaceSnap.Resources, 2)
|
|
assert.Equal(t, replaceSnap.Resources[0].URN.Name(), "default")
|
|
assert.Equal(t, replaceSnap.Resources[1].URN.Name(), "resA")
|
|
assert.True(t, deleteCalled, "Delete should be called as part of replacement")
|
|
assert.True(t, replaceSnap.Resources[1].PendingReplacement)
|
|
|
|
// Operation 3 -- resume the replacement with the same program.
|
|
deleteCalled = false
|
|
createCalled = false
|
|
|
|
removeLoaders := []*deploytest.ProviderLoader{
|
|
deploytest.NewProviderLoader("pkgA", semver.MustParse("1.0.0"), func() (plugin.Provider, error) {
|
|
return &deploytest.Provider{
|
|
DiffF: returnReplaceDiff,
|
|
DeleteF: trackedDelete,
|
|
CreateF: trackedCreate,
|
|
}, nil
|
|
}),
|
|
}
|
|
|
|
removeHostF := deploytest.NewPluginHostF(nil, nil, programF, removeLoaders...)
|
|
removeOptions := TestUpdateOptions{T: t, HostF: removeHostF}
|
|
|
|
removeSnap, err := TestOp(Update).
|
|
RunStep(project, p.GetTarget(t, replaceSnap), removeOptions, false, p.BackendClient, nil, "2")
|
|
assert.NoError(t, err)
|
|
|
|
// Assert.
|
|
assert.Len(t, removeSnap.Resources, 2)
|
|
assert.Equal(t, removeSnap.Resources[0].URN.Name(), "default")
|
|
assert.Equal(t, removeSnap.Resources[1].URN.Name(), "resA")
|
|
assert.False(t, deleteCalled, "Delete shouldn't be called a second time when resuming a replacement (same goals)")
|
|
assert.True(t, createCalled, "Create should be called when resuming a replacement (same goals)")
|
|
assert.False(t, removeSnap.Resources[1].PendingReplacement)
|
|
}
|
|
|
|
// Tests that a delete-before-replace operation:
|
|
//
|
|
// * that is interrupted after the deletion (e.g. with a failed create)
|
|
// * and then resumed, with a new program that removes the deleted resource
|
|
//
|
|
// will:
|
|
//
|
|
// * not call delete (again) on the old resource
|
|
// * remove the old resource from the state
|
|
func TestPendingReplaceResumeWithDeletedGoals(t *testing.T) {
|
|
t.Parallel()
|
|
|
|
// Arrange.
|
|
p := &TestPlan{}
|
|
project := p.GetProject()
|
|
|
|
returnReplaceDiff := func(
|
|
urn resource.URN,
|
|
id resource.ID,
|
|
oldInputs, oldOutputs, newInputs resource.PropertyMap,
|
|
ignoreChanges []string,
|
|
) (plugin.DiffResult, error) {
|
|
if urn.Name() == "resA" {
|
|
return plugin.DiffResult{
|
|
Changes: plugin.DiffSome,
|
|
ReplaceKeys: []resource.PropertyKey{"key"},
|
|
DeleteBeforeReplace: true,
|
|
}, nil
|
|
}
|
|
|
|
return plugin.DiffResult{}, nil
|
|
}
|
|
|
|
deleteCalled := false
|
|
trackedDelete := func(
|
|
urn resource.URN,
|
|
id resource.ID,
|
|
oldInputs, oldOutputs resource.PropertyMap,
|
|
timeout float64,
|
|
) (resource.Status, error) {
|
|
deleteCalled = true
|
|
return resource.StatusOK, nil
|
|
}
|
|
|
|
createCalled := false
|
|
throwingCreate := func(
|
|
urn resource.URN,
|
|
news resource.PropertyMap,
|
|
timeout float64,
|
|
preview bool,
|
|
) (resource.ID, resource.PropertyMap, resource.Status, error) {
|
|
createCalled = true
|
|
return "", news, resource.StatusUnknown, errors.New("interrupt replace")
|
|
}
|
|
|
|
trackedCreate := func(
|
|
urn resource.URN,
|
|
news resource.PropertyMap,
|
|
timeout float64,
|
|
preview bool,
|
|
) (resource.ID, resource.PropertyMap, resource.Status, error) {
|
|
createCalled = true
|
|
return "created-id", news, resource.StatusOK, nil
|
|
}
|
|
|
|
// Act.
|
|
|
|
// Operation 1 -- initialise the state with a resource.
|
|
upLoaders := []*deploytest.ProviderLoader{
|
|
deploytest.NewProviderLoader("pkgA", semver.MustParse("1.0.0"), func() (plugin.Provider, error) {
|
|
return &deploytest.Provider{}, nil
|
|
}),
|
|
}
|
|
|
|
programF := deploytest.NewLanguageRuntimeF(func(_ plugin.RunInfo, monitor *deploytest.ResourceMonitor) error {
|
|
_, err := monitor.RegisterResource("pkgA:m:typA", "resA", true)
|
|
assert.NoError(t, err)
|
|
|
|
return nil
|
|
})
|
|
|
|
upHostF := deploytest.NewPluginHostF(nil, nil, programF, upLoaders...)
|
|
upOptions := TestUpdateOptions{T: t, HostF: upHostF}
|
|
|
|
upSnap, err := TestOp(Update).
|
|
RunStep(project, p.GetTarget(t, nil), upOptions, false, p.BackendClient, nil, "0")
|
|
assert.NoError(t, err)
|
|
|
|
assert.Len(t, upSnap.Resources, 2)
|
|
assert.Equal(t, upSnap.Resources[0].URN.Name(), "default")
|
|
assert.Equal(t, upSnap.Resources[1].URN.Name(), "resA")
|
|
|
|
// Operation 2 -- return a replacing diff and interrupt it with a failing
|
|
// create.
|
|
replaceLoaders := []*deploytest.ProviderLoader{
|
|
deploytest.NewProviderLoader("pkgA", semver.MustParse("1.0.0"), func() (plugin.Provider, error) {
|
|
return &deploytest.Provider{
|
|
DiffF: returnReplaceDiff,
|
|
DeleteF: trackedDelete,
|
|
CreateF: throwingCreate,
|
|
}, nil
|
|
}),
|
|
}
|
|
|
|
replaceHostF := deploytest.NewPluginHostF(nil, nil, programF, replaceLoaders...)
|
|
replaceOptions := TestUpdateOptions{T: t, HostF: replaceHostF}
|
|
|
|
replaceSnap, err := TestOp(Update).
|
|
RunStep(project, p.GetTarget(t, upSnap), replaceOptions, false, p.BackendClient, nil, "1")
|
|
assert.ErrorContains(t, err, "interrupt replace")
|
|
|
|
assert.Len(t, replaceSnap.Resources, 2)
|
|
assert.Equal(t, replaceSnap.Resources[0].URN.Name(), "default")
|
|
assert.Equal(t, replaceSnap.Resources[1].URN.Name(), "resA")
|
|
assert.True(t, deleteCalled, "Delete should be called as part of replacement")
|
|
assert.True(t, replaceSnap.Resources[1].PendingReplacement)
|
|
|
|
// Operation 3 -- resume the replacement with a program that removes the
|
|
// resource.
|
|
deleteCalled = false
|
|
createCalled = false
|
|
|
|
removeLoaders := []*deploytest.ProviderLoader{
|
|
deploytest.NewProviderLoader("pkgA", semver.MustParse("1.0.0"), func() (plugin.Provider, error) {
|
|
return &deploytest.Provider{
|
|
DiffF: returnReplaceDiff,
|
|
DeleteF: trackedDelete,
|
|
CreateF: trackedCreate,
|
|
}, nil
|
|
}),
|
|
}
|
|
|
|
// Remove the resource from the program before resuming by providing an empty
|
|
// program.
|
|
removeProgramF := deploytest.NewLanguageRuntimeF(func(_ plugin.RunInfo, monitor *deploytest.ResourceMonitor) error {
|
|
return nil
|
|
})
|
|
|
|
removeHostF := deploytest.NewPluginHostF(nil, nil, removeProgramF, removeLoaders...)
|
|
removeOptions := TestUpdateOptions{T: t, HostF: removeHostF}
|
|
|
|
removeSnap, err := TestOp(Update).
|
|
RunStep(project, p.GetTarget(t, replaceSnap), removeOptions, false, p.BackendClient, nil, "2")
|
|
assert.NoError(t, err)
|
|
|
|
// Assert.
|
|
assert.Len(t, removeSnap.Resources, 0)
|
|
assert.False(t, deleteCalled, "Delete shouldn't be called a second time when resuming a replacement (deleted goals)")
|
|
assert.False(t, createCalled, "Create shouldn't be called when resuming a replacement (deleted goals)")
|
|
}
|
|
|
|
// Tests that a delete-before-replace operation:
|
|
//
|
|
// - that is interrupted after the deletion (e.g. with a failed create)
|
|
// - and then resumed, with a new program that updates the deleted resource with
|
|
// a diff that _does not_ require replacement
|
|
//
|
|
// will:
|
|
//
|
|
// * not call delete (again) on the old resource
|
|
// * remove the PendingReplacement flag from the resource in state
|
|
// * call create on the new resource with the updated goals
|
|
// * remove the old resource from the state
|
|
//
|
|
// thereby _actually_ replacing the resource despite the new diff in order to
|
|
// complete the interrupted replacement.
|
|
func TestPendingReplaceResumeWithUpdatedGoals(t *testing.T) {
|
|
t.Parallel()
|
|
|
|
// Arrange.
|
|
p := &TestPlan{}
|
|
project := p.GetProject()
|
|
|
|
returnReplaceDiff := func(
|
|
urn resource.URN,
|
|
id resource.ID,
|
|
oldInputs, oldOutputs, newInputs resource.PropertyMap,
|
|
ignoreChanges []string,
|
|
) (plugin.DiffResult, error) {
|
|
if urn.Name() == "resA" {
|
|
return plugin.DiffResult{
|
|
Changes: plugin.DiffSome,
|
|
ReplaceKeys: []resource.PropertyKey{"key"},
|
|
DeleteBeforeReplace: true,
|
|
}, nil
|
|
}
|
|
|
|
return plugin.DiffResult{}, nil
|
|
}
|
|
|
|
returnNonReplaceDiff := func(
|
|
urn resource.URN,
|
|
id resource.ID,
|
|
oldInputs, oldOutputs, newInputs resource.PropertyMap,
|
|
ignoreChanges []string,
|
|
) (plugin.DiffResult, error) {
|
|
if urn.Name() == "resA" {
|
|
return plugin.DiffResult{
|
|
Changes: plugin.DiffSome,
|
|
DeleteBeforeReplace: true,
|
|
}, nil
|
|
}
|
|
|
|
return plugin.DiffResult{}, nil
|
|
}
|
|
|
|
deleteCalled := false
|
|
trackedDelete := func(
|
|
urn resource.URN,
|
|
id resource.ID,
|
|
oldInputs, oldOutputs resource.PropertyMap,
|
|
timeout float64,
|
|
) (resource.Status, error) {
|
|
deleteCalled = true
|
|
return resource.StatusOK, nil
|
|
}
|
|
|
|
createCalled := false
|
|
throwingCreate := func(
|
|
urn resource.URN,
|
|
news resource.PropertyMap,
|
|
timeout float64,
|
|
preview bool,
|
|
) (resource.ID, resource.PropertyMap, resource.Status, error) {
|
|
createCalled = true
|
|
return "", news, resource.StatusUnknown, errors.New("interrupt replace")
|
|
}
|
|
|
|
trackedCreate := func(
|
|
urn resource.URN,
|
|
news resource.PropertyMap,
|
|
timeout float64,
|
|
preview bool,
|
|
) (resource.ID, resource.PropertyMap, resource.Status, error) {
|
|
createCalled = true
|
|
return "created-id", news, resource.StatusOK, nil
|
|
}
|
|
|
|
// Act.
|
|
|
|
// Operation 1 -- initialise the state with a resource.
|
|
upLoaders := []*deploytest.ProviderLoader{
|
|
deploytest.NewProviderLoader("pkgA", semver.MustParse("1.0.0"), func() (plugin.Provider, error) {
|
|
return &deploytest.Provider{}, nil
|
|
}),
|
|
}
|
|
|
|
programF := deploytest.NewLanguageRuntimeF(func(_ plugin.RunInfo, monitor *deploytest.ResourceMonitor) error {
|
|
_, err := monitor.RegisterResource("pkgA:m:typA", "resA", true)
|
|
assert.NoError(t, err)
|
|
|
|
return nil
|
|
})
|
|
|
|
upHostF := deploytest.NewPluginHostF(nil, nil, programF, upLoaders...)
|
|
upOptions := TestUpdateOptions{T: t, HostF: upHostF}
|
|
|
|
upSnap, err := TestOp(Update).
|
|
RunStep(project, p.GetTarget(t, nil), upOptions, false, p.BackendClient, nil, "0")
|
|
assert.NoError(t, err)
|
|
|
|
assert.Len(t, upSnap.Resources, 2)
|
|
assert.Equal(t, upSnap.Resources[0].URN.Name(), "default")
|
|
assert.Equal(t, upSnap.Resources[1].URN.Name(), "resA")
|
|
|
|
// Operation 2 -- return a replacing diff and interrupt it with a failing
|
|
// create.
|
|
replaceLoaders := []*deploytest.ProviderLoader{
|
|
deploytest.NewProviderLoader("pkgA", semver.MustParse("1.0.0"), func() (plugin.Provider, error) {
|
|
return &deploytest.Provider{
|
|
DiffF: returnReplaceDiff,
|
|
DeleteF: trackedDelete,
|
|
CreateF: throwingCreate,
|
|
}, nil
|
|
}),
|
|
}
|
|
|
|
replaceHostF := deploytest.NewPluginHostF(nil, nil, programF, replaceLoaders...)
|
|
replaceOptions := TestUpdateOptions{T: t, HostF: replaceHostF}
|
|
|
|
replaceSnap, err := TestOp(Update).
|
|
RunStep(project, p.GetTarget(t, upSnap), replaceOptions, false, p.BackendClient, nil, "1")
|
|
assert.ErrorContains(t, err, "interrupt replace")
|
|
|
|
assert.Len(t, replaceSnap.Resources, 2)
|
|
assert.Equal(t, replaceSnap.Resources[0].URN.Name(), "default")
|
|
assert.Equal(t, replaceSnap.Resources[1].URN.Name(), "resA")
|
|
assert.True(t, deleteCalled, "Delete should be called as part of replacement")
|
|
assert.True(t, replaceSnap.Resources[1].PendingReplacement)
|
|
|
|
// Operation 3 -- resume the replacement with a program that triggers a
|
|
// non-replacing diff (for the purposes of the test we do this by mocking the
|
|
// Diff call rather than updating the program, but the effect should be the
|
|
// same).
|
|
deleteCalled = false
|
|
createCalled = false
|
|
|
|
removeLoaders := []*deploytest.ProviderLoader{
|
|
deploytest.NewProviderLoader("pkgA", semver.MustParse("1.0.0"), func() (plugin.Provider, error) {
|
|
return &deploytest.Provider{
|
|
DiffF: returnNonReplaceDiff,
|
|
DeleteF: trackedDelete,
|
|
CreateF: trackedCreate,
|
|
}, nil
|
|
}),
|
|
}
|
|
|
|
removeHostF := deploytest.NewPluginHostF(nil, nil, programF, removeLoaders...)
|
|
removeOptions := TestUpdateOptions{T: t, HostF: removeHostF}
|
|
|
|
removeSnap, err := TestOp(Update).
|
|
RunStep(project, p.GetTarget(t, replaceSnap), removeOptions, false, p.BackendClient, nil, "2")
|
|
assert.NoError(t, err)
|
|
|
|
// Assert.
|
|
assert.Len(t, removeSnap.Resources, 2)
|
|
assert.Equal(t, removeSnap.Resources[0].URN.Name(), "default")
|
|
assert.Equal(t, removeSnap.Resources[1].URN.Name(), "resA")
|
|
assert.False(t, deleteCalled, "Delete shouldn't be called a second time when resuming a replacement (updated goals)")
|
|
assert.True(t, createCalled, "Create should be called when resuming a replacement (updated goals)")
|
|
assert.False(t, removeSnap.Resources[1].PendingReplacement)
|
|
}
|