mirrors
/
pulumi
mirror of https://github.com/pulumi/pulumi.git
0
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
pulumi/pkg/engine/lifecycletest
History
Ramon Quitales ba76f29997
Fix --continue-on-error running indefinitely when a resource fails to be created or updated (#16371) 
<!--- 
Thanks so much for your contribution! If this is your first time
contributing, please ensure that you have read the
[CONTRIBUTING](https://github.com/pulumi/pulumi/blob/master/CONTRIBUTING.md)
documentation.
-->

# Description

This PR ensures that we only run the `StepCompleteFunc` if the step is
successful. If not, we should use the step's `Fail` method to register
the result. Previously, when a user runs a pulumi up operation with
`--continue-on-error`, the engine would register the result twice, once
in
ee6ec150d8/pkg/resource/deploy/step_executor.go (L342)
and if a failure occurs, it is re-registered in
ee6ec150d8/pkg/resource/deploy/step_executor.go (L373)
I suspect that the double registration is the cause of the user facing
error. Since this would only occur for create and update steps, it also
explains why the error doesn't occur during deletions.

Testing:

- Manually ran the repro identified in #16373 and
https://github.com/pulumi/pulumi-command/issues/435#issuecomment-2114250614
against a locally built CLI with this fix.
- Extended existing lifecycle tests to account for the different code
branches of `CreateStep.Apply()` and `UpdateStep.Apply()`

Fixes #16373

## Checklist

- [x] I have run `make tidy` to update any new dependencies
- [x] I have run `make lint` to verify my code passes the lint check
  - [x] I have formatted my code using `gofumpt`

<!--- Please provide details if the checkbox below is to be left
unchecked. -->
- [x] I have added tests that prove my fix is effective or that my
feature works
<!--- 
User-facing changes require a CHANGELOG entry.
-->
- [x] I have run `make changelog` and committed the
`changelog/pending/<file>` documenting my change
<!--
If the change(s) in this PR is a modification of an existing call to the
Pulumi Cloud,
then the service should honor older versions of the CLI where this
change would not exist.
You must then bump the API version in
/pkg/backend/httpstate/client/api.go, as well as add
it to the service.
-->
- [ ] Yes, there are changes in this PR that warrants bumping the Pulumi
Cloud API version
<!-- @Pulumi employees: If yes, you must submit corresponding changes in
the service repo. -->
 		2024-06-13 15:42:57 +00:00
..
testdata Change `pulumi refresh` to report diff relative to desired state instead of relative to only output changes (#16146) 2024-06-12 16:17:05 +00:00
alias_test.go Add display to the engine tests (#16050) 2024-05-13 07:18:25 +00:00
analyzer_test.go Add display to the engine tests (#16050) 2024-05-13 07:18:25 +00:00
continue_on_error_test.go Fix --continue-on-error running indefinitely when a resource fails to be created or updated (#16371) 2024-06-13 15:42:57 +00:00
delete_before_replace_test.go Add display to the engine tests (#16050) 2024-05-13 07:18:25 +00:00
golang_sdk_test.go Add display to the engine tests (#16050) 2024-05-13 07:18:25 +00:00
import_test.go Normalize plugin.Provider methods to (Context, Request) -> (Response, error) (#16302) 2024-06-07 19:47:49 +00:00
parameterized_test.go Initial work for parameterized providers (#16281) 2024-06-10 17:28:47 +00:00
pending_delete_test.go Add display to the engine tests (#16050) 2024-05-13 07:18:25 +00:00
provider_test.go Add display to the engine tests (#16050) 2024-05-13 07:18:25 +00:00
pulumi_test.go Add display to the engine tests (#16050) 2024-05-13 07:18:25 +00:00
refresh_legacy_diff_test.go Change `pulumi refresh` to report diff relative to desired state instead of relative to only output changes (#16146) 2024-06-12 16:17:05 +00:00
refresh_test.go Change `pulumi refresh` to report diff relative to desired state instead of relative to only output changes (#16146) 2024-06-12 16:17:05 +00:00
resource_reference_test.go Add display to the engine tests (#16050) 2024-05-13 07:18:25 +00:00
source_query_test.go deploytest/RegisterResource: return struct instead of values (#15988) 2024-04-19 11:08:56 +00:00
step_generator_test.go Add display to the engine tests (#16050) 2024-05-13 07:18:25 +00:00
target_test.go Propagate deleted dependencies of untargeted resources (#16247) 2024-05-23 12:31:03 +00:00
test_plan.go Normalize plugin.Provider methods to (Context, Request) -> (Response, error) (#16302) 2024-06-07 19:47:49 +00:00
transformation_test.go Add display to the engine tests (#16050) 2024-05-13 07:18:25 +00:00
update_plan_test.go Add display to the engine tests (#16050) 2024-05-13 07:18:25 +00:00