mirrors
/
pulumi
mirror of https://github.com/pulumi/pulumi.git
0
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
pulumi/tests/integration
History
Will Jones c496921d44
Enable some more linting rules (#17456) 
Issue #10659 lists a number of extra linting checks that we could enable
in order to make our Go code more robust. This commit implements as many
as seem sensible:

* `durationcheck`, which checks for multiplication of `time.Duration`s,
which can lead to unexpected behaviour (e.g. `time.Second * time.Second`
is *not* one second)
* `goprintffuncname`, which checks that `Printf`-like functions are
appropriately suffixed with `f` to indicate as such
* `tenv`, which checks for `os.Setenv` in tests where `t.Setenv` is
generally a better solution
* `wastedassign`, which checks for assignments whose values are never
used (such as initial values before an `if` where both branches then
overwrite the value)
* `whitespace`, which checks for blank lines at the beginning and end of
blocks such as functions, `if`s, `for`s and so on.

This commit does *not* enable the following checks listed in #10659:

* `wrapcheck`, which insists that third-party library errors are always
`%w`rapped -- we have a lot of cases where we don't do this and it's
probably a bit more involved than "just wrap them" in terms of making
sure we don't break anything (maybe)
* `predeclared`, which checks for shadowing of existing Go identifiers
-- we use `old` and `new` a lot, especially in step generation, so this
is probably a slightly bigger clean-up/one we might want to opt out of
* `mnd` (magic number detection) -- we have a lot of failures on this
* `nilnil` -- we only have a couple of failures on this; these could
probably be handled with `//nolint` but for now I've opted not to take
this route.
 		2024-10-03 17:37:13 +00:00
..
about Bump go modules (#16051) 2024-04-25 14:30:00 +00:00
aliases Enable goheader rule and add missing license headers (#15473) 2024-09-09 12:05:45 +00:00
backend/diy fix dll loading errors in windows CI (#17410) 2024-10-02 08:43:42 +00:00
cloud_secrets_provider Enable full strict mode. (#3218) 2019-09-11 16:21:35 -07:00
component_provider_schema Add RunPlugin support for python 2023-03-06 21:35:39 +00:00
config_basic Bump go modules (#16051) 2024-04-25 14:30:00 +00:00
config_capture_e2e/nodejs Revert package.json lookup fix. 2023-05-15 14:14:57 -04:00
config_missing Bump go modules (#16051) 2024-04-25 14:30:00 +00:00
config_secrets_warn Bump go modules (#16051) 2024-04-25 14:30:00 +00:00
construct_component Bump go modules (#16051) 2024-04-25 14:30:00 +00:00
construct_component_configure_provider fix dll loading errors in windows CI (#17410) 2024-10-02 08:43:42 +00:00
construct_component_error_apply Update @types/node version in tests 2023-02-07 14:20:27 +00:00
construct_component_failures allow better grpc error messages from NodeJS component providers (#17325) 2024-10-03 10:06:37 +00:00
construct_component_id_output [python/sdk] Allow remote components to use output property called id (#15115) 2024-01-18 13:54:09 +00:00
construct_component_methods Bump go modules (#16051) 2024-04-25 14:30:00 +00:00
construct_component_methods_errors Bump go modules (#16051) 2024-04-25 14:30:00 +00:00
construct_component_methods_provider Bump the go_modules group across 5 directories with 1 update (#16054) 2024-04-25 21:11:41 +00:00
construct_component_methods_resources Bump go modules (#16051) 2024-04-25 14:30:00 +00:00
construct_component_methods_unknown Bump go modules (#16051) 2024-04-25 14:30:00 +00:00
construct_component_output_values Bump go modules (#16051) 2024-04-25 14:30:00 +00:00
construct_component_plain Bump go modules (#16051) 2024-04-25 14:30:00 +00:00
construct_component_provider Bump go modules (#16051) 2024-04-25 14:30:00 +00:00
construct_component_provider_explicit Bump go modules (#16051) 2024-04-25 14:30:00 +00:00
construct_component_provider_propagation fix dll loading errors in windows CI (#17410) 2024-10-02 08:43:42 +00:00
construct_component_resource_options fix dll loading errors in windows CI (#17410) 2024-10-02 08:43:42 +00:00
construct_component_slow Update @types/node version in tests 2023-02-07 14:20:27 +00:00
construct_component_unknown Bump the go_modules group across 5 directories with 1 update (#16054) 2024-04-25 21:11:41 +00:00
construct_nested_component/go fix dll loading errors in windows CI (#17410) 2024-10-02 08:43:42 +00:00
custom_timeouts Enable goheader rule and add missing license headers (#15473) 2024-09-09 12:05:45 +00:00
delete_before_create Enable goheader rule and add missing license headers (#15473) 2024-09-09 12:05:45 +00:00
deleted_with Bump the go_modules group across 5 directories with 1 update (#16054) 2024-04-25 21:11:41 +00:00
dependency_steps Enable goheader rule and add missing license headers (#15473) 2024-09-09 12:05:45 +00:00
double_pending_delete Enable goheader rule and add missing license headers (#15473) 2024-09-09 12:05:45 +00:00
duplicate_urns Enable goheader rule and add missing license headers (#15473) 2024-09-09 12:05:45 +00:00
dynamic Allow Python dynamic providers to capture secrets (#15864) 2024-08-02 23:51:52 +00:00
ee_perf Use prefered `new pulumi.Config()` form 2019-01-31 16:11:57 -08:00
empty Bump the go_modules group across 24 directories with 1 update (#15685) 2024-03-14 07:52:34 +00:00
enums [tests/integration] Remove `pulumi` from `requirements.txt` (#15226) 2024-01-24 14:16:40 +00:00
environments_basic [environments] Add integration tests (#14144) 2023-10-12 16:39:26 +00:00
environments_merge [environments] Add integration tests (#14144) 2023-10-12 16:39:26 +00:00
exclude_protected Implement the --exclude-protected feature (#8359) 2021-11-15 11:45:14 -08:00
explicit_provider Remove unused `package.json` files from tests (#13162) 2024-07-08 14:09:16 +00:00
gather_plugin Bump the go_modules group across 24 directories with 1 update (#15685) 2024-03-14 07:52:34 +00:00
get_created Remove unused `package.json` files from tests (#13162) 2024-07-08 14:09:16 +00:00
get_resource Bump the go_modules group across 24 directories with 1 update (#15685) 2024-03-14 07:52:34 +00:00
go fix dll loading errors in windows CI (#17410) 2024-10-02 08:43:42 +00:00
invalid_package_json Revert package.json lookup fix. 2023-05-15 14:14:57 -04:00
large_resource Bump the go_modules group across 24 directories with 1 update (#15685) 2024-03-14 07:52:34 +00:00
nodejs Fix dependency installation for nodejs projects with a main property (#17391) 2024-09-26 15:22:28 +00:00
partial_state Enable goheader rule and add missing license headers (#15473) 2024-09-09 12:05:45 +00:00
partial_values Propagate inputs to outputs during preview. (#3327) 2019-11-11 12:09:34 -08:00
policy Enable goheader rule and add missing license headers (#15473) 2024-09-09 12:05:45 +00:00
printf Bump the go_modules group across 24 directories with 1 update (#15685) 2024-03-14 07:52:34 +00:00
project_main Bump the go_modules group across 24 directories with 1 update (#15685) 2024-03-14 07:52:34 +00:00
project_main_abs Enable absolute and relative parent paths for pulumi main (#6734) 2021-04-08 21:39:52 -07:00
project_main_parent/foo Enable absolute and relative parent paths for pulumi main (#6734) 2021-04-08 21:39:52 -07:00
protect_resources Enable goheader rule and add missing license headers (#15473) 2024-09-09 12:05:45 +00:00
provider_secret_config Enable full strict mode. (#3218) 2019-09-11 16:21:35 -07:00
python Search upwards for pyproject.toml when using Poetry (#17388) 2024-09-26 15:13:21 +00:00
python_await Cleanup output futures list as they complete (#16057) 2024-04-26 16:35:28 +00:00
query Enable goheader rule and add missing license headers (#15473) 2024-09-09 12:05:45 +00:00
read Enable goheader rule and add missing license headers (#15473) 2024-09-09 12:05:45 +00:00
recreate_resource_check Enable goheader rule and add missing license headers (#15473) 2024-09-09 12:05:45 +00:00
refresh/go Bump the go_modules group across 24 directories with 1 update (#15685) 2024-03-14 07:52:34 +00:00
resource_refs_get_resource ResourceRefsGetResourceGo: also wait for the childs message to be registered (#17116) 2024-09-03 10:35:37 +00:00
rotate_passphrase Bump the go_modules group across 5 directories with 1 update (#16054) 2024-04-25 21:11:41 +00:00
secret_outputs [sdk/python] Fix secret regression (#5496) 2020-10-01 14:57:51 -07:00
single_resource Suppress JSON outputs in preview correctly (#2771) 2019-05-25 12:10:38 +02:00
stack_bad_parenting Consistent dependencies (#2517) 2019-03-05 20:34:51 -08:00
stack_dependencies Remove existing lock files 2018-11-12 15:33:58 -08:00
stack_outputs Remove dotnet 2022-12-13 16:13:53 +00:00
stack_outputs_program_error fix dll loading errors in windows CI (#17410) 2024-10-02 08:43:42 +00:00
stack_outputs_resource_error fix dll loading errors in windows CI (#17410) 2024-10-02 08:43:42 +00:00
stack_parenting Consistent dependencies (#2517) 2019-03-05 20:34:51 -08:00
stack_project_name Actually fix the naming test (#10554) 2022-08-31 20:52:23 +01:00
state_rename_parent Bump the go_modules group across 5 directories with 1 update (#16054) 2024-04-25 21:11:41 +00:00
steps Enable goheader rule and add missing license headers (#15473) 2024-09-09 12:05:45 +00:00
targets Enable goheader rule and add missing license headers (#15473) 2024-09-09 12:05:45 +00:00
transformations fix dll loading errors in windows CI (#17410) 2024-10-02 08:43:42 +00:00
transforms fix dll loading errors in windows CI (#17410) 2024-10-02 08:43:42 +00:00
tsconfig Add tsconfig option to specify tsconfig path (#8452) 2021-11-22 11:42:39 -08:00
types Enable goheader rule and add missing license headers (#15473) 2024-09-09 12:05:45 +00:00
unsafe_snapshot_tests/bad_resource Update tests/integration/unsafe_snapshot_tests/bad_resource/resource.ts 2022-09-15 08:00:36 -07:00
valid-property-names Enable goheader rule and add missing license headers (#15473) 2024-09-09 12:05:45 +00:00
.gitignore ci: Enable async component builds 2022-09-14 10:06:05 -07:00
appdash_test.go Enable goheader rule and add missing license headers (#15473) 2024-09-09 12:05:45 +00:00
component_setup.sh Engine and Golang support for shimless providers 2022-11-14 11:25:41 +00:00
integration_acceptance_test.go Run Environment.DeleteIfNotFailed after tests complete (#16730) 2024-07-23 10:37:01 +00:00
integration_go_acceptance_test.go test: Update deps (#16010) 2024-04-24 05:07:52 +00:00
integration_go_test.go python: add test showing that attaching a debugger works (#17270) 2024-09-17 10:13:32 +00:00
integration_nodejs_acceptance_test.go Run Environment.DeleteIfNotFailed after tests complete (#16730) 2024-07-23 10:37:01 +00:00
integration_nodejs_test.go Enable some more linting rules (#17456) 2024-10-03 17:37:13 +00:00
integration_python_acceptance_test.go Search upwards for pyproject.toml when using Poetry (#17388) 2024-09-26 15:13:21 +00:00
integration_python_test.go Fix Python min parameterization version (#17317) 2024-09-20 06:23:27 +00:00
integration_test.go Install missing python versions using pyenv during installation (#16855) 2024-08-19 15:55:54 +00:00
integration_util_test.go allow better grpc error messages from NodeJS component providers (#17325) 2024-10-03 10:06:37 +00:00