mirror of https://github.com/pulumi/pulumi.git
2248fee20d
11747: testing/integration: Fix failure without GOPATH r=abhinav a=abhinav TestGoModEdits requires that one of the following conditions be true for the test to pass: - pulumi/pulumi is checked out at $GOPATH/src/github.com/pulumi/pulumi - PULUMI_GO_DEP_ROOT is set to the directory where it's checked out With wide usage of Go modules, we're less likely to have folks working under GOPATH. As for PULUMI_GO_DEP_ROOT, it makes sense for the generic utility: Being able to specify where the dependency is checked out is useful on a per-project basis, but it makes less sense for this test. This test is specifically checking the values inside the sdk/go.mod and the path for that is always fixed. This change modifies TestGoModEdits to pass no matter where the repository is checked out -- as long as it's called "pulumi". It does so by hard-coding the position of the repository root relative to the test directory. This *feels* slightly icky because depRoot refers to the directory that contains the "pulumi" directory, but I think that this is less likely to break and easier to fix, versus looking for a go.mod file as the project structure evolves over time. 11757: Fix spelling of passphrase r=Frassle a=Frassle Co-authored-by: Abhinav Gupta <abhinav@pulumi.com> Co-authored-by: Fraser Waters <fraser@pulumi.com> |
||
|---|---|---|
| .. | ||
| authhelpers | ||
| backend | ||
| cmd/pulumi | ||
| codegen | ||
| engine | ||
| graph | ||
| operations | ||
| resource | ||
| secrets | ||
| testing/integration | ||
| util | ||
| version | ||
| README.md | ||
| go.mod | ||
| go.sum | ||
README.md
pulumi/pkg
While pulumi/sdk maintains strict backwards compatibility guarantees, code under pkg/ is handled more informally: while breaking changes are still discouraged they may happen when they make sense.