mirror of https://github.com/pulumi/pulumi.git
7148ef364b
12954: Eliminate assignment statements used as expressions. r=RobbieMcKinstry a=RobbieMcKinstry <!--- Thanks so much for your contribution! If this is your first time contributing, please ensure that you have read the [CONTRIBUTING](https://github.com/pulumi/pulumi/blob/master/CONTRIBUTING.md) documentation. --> # Description <!--- Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. --> Eliminate assignment statements used as expressions. This change refactors assignment statements used as expressions to prefer assignment statements instead. Assignments are often assumed to now evaluate to a value, but instead to represent a change to a lexical binding. By using them as expressions, we can write confusing and buggy code. This commit eliminates those instances and enables a lint to prevent future occurrences. ## Checklist **N/A:** This PR is strictly a non-functional change. <!--- Please provide details if the checkbox below is to be left unchecked. --> - [ ] I have added tests that prove my fix is effective or that my feature works <!--- User-facing changes require a CHANGELOG entry. --> - [ ] I have run `make changelog` and committed the `changelog/pending/<file>` documenting my change <!-- If the change(s) in this PR is a modification of an existing call to the Pulumi Cloud, then the service should honor older versions of the CLI where this change would not exist. You must then bump the API version in /pkg/backend/httpstate/client/api.go, as well as add it to the service. --> - [ ] Yes, there are changes in this PR that warrants bumping the Pulumi Cloud API version <!-- `@Pulumi` employees: If yes, you must submit corresponding changes in the service repo. --> Co-authored-by: Robbie McKinstry <robbie@pulumi.com> |
||
|---|---|---|
| .. | ||
| go | ||
| nodejs | ||
| proto/go | ||
| python | ||
| README.md | ||
| go.mod | ||
| go.sum | ||