mirror of https://github.com/pulumi/pulumi.git
a28454477c
# Description This PR implements generating the generic variant of a go SDK from Pulumi schemas. Currently the idea is to generate a directory `x` inside the root directory of the go SDK which will contain the same SDK except using generics and generating far less code than its current counter part. Also implements an enum option `$.language.go.generics` which can be set to the following: - `none` is the default which maintains the current behavior that generates legacy types without generics - `side-by-side` generates the generics sdk variant alongside the current sdk under directory `x` - `generics-only` generates only the new sdk with generics at the root of the package Still a bunch of things to do: - [x] Generating `InvokeResult]Output` type from `Output[InvokeResult]` and generating accessor methods for it - [x] Generating default values for types and using the `pulumix` subpackage to do so - [x] Generating generic SDK variants for all test schemas we have and making sure they compile (currently only testing `simple-resource-schema` as shown below) - [x] Account for plain inputs for components - [x] Combine pulumix.Join with pulumix.Apply to generate resource accessor methods - [x] Problem with `GPtrOutput[T]` and `ArrayOutput[T]` being unwrapped to `Output[*T]` and `Output[[]T]` - [x] Remove excess untyped container types from generated enums - [x] Fix default values for resource methods with lifted single return value - [x] Secret properties Currently the following test schemas have opted for `generics: "side-by-side"`: - [x] output-funcs - [x] simple-enum-schema - [x] secrets - [x] simple-plain-schema - [x] plain-and-default ## Checklist - [ ] I have run `make tidy` to update any new dependencies - [x] I have run `make lint` to verify my code passes the lint check - [ ] I have formatted my code using `gofumpt` <!--- Please provide details if the checkbox below is to be left unchecked. --> - [x] I have added tests that prove my fix is effective or that my feature works <!--- User-facing changes require a CHANGELOG entry. --> - [x] I have run `make changelog` and committed the `changelog/pending/<file>` documenting my change <!-- If the change(s) in this PR is a modification of an existing call to the Pulumi Cloud, then the service should honor older versions of the CLI where this change would not exist. You must then bump the API version in /pkg/backend/httpstate/client/api.go, as well as add it to the service. --> - [ ] Yes, there are changes in this PR that warrants bumping the Pulumi Cloud API version <!-- @Pulumi employees: If yes, you must submit corresponding changes in the service repo. --> |
||
|---|---|---|
| .. | ||
| pending | ||
| config.yaml | ||