pulumi/pkg/importer
Zaid Ajaj bf606d33e8
[engine/import] Guess ID references of dependant resources when generating code for import operations (#16208)
### Description

Taking an initial attempt at #10025 where we now try to guess ID
references of dependant resources instead of writing out the IDs as
literal values.
Instead of:
```hcl
// has ID=provider-generated-bucket-id-abc123
resource exampleBucket "aws:s3/bucket:Bucket" {}

resource exampleBucketObject "aws:s3/bucketObject:BucketObject" {
    bucket = "provider-generated-bucket-id-abc123"
    storageClass = "STANDARD"
}
```
We generate:
```hcl
resource exampleBucket "aws:s3/bucket:Bucket" {}

resource exampleBucketObject "aws:s3/bucketObject:BucketObject" {
    bucket = exampleBucket.id
    storageClass = "STANDARD"
}
```
This implies a dependency between `exampleBucketObject` and
`exampleBucket` without explicitly being added into the `dependsOn`
array (it would be redundant)

## Checklist

- [x] I have run `make tidy` to update any new dependencies
- [x] I have run `make lint` to verify my code passes the lint check
  - [ ] I have formatted my code using `gofumpt`

<!--- Please provide details if the checkbox below is to be left
unchecked. -->
- [x] I have added tests that prove my fix is effective or that my
feature works
<!--- 
User-facing changes require a CHANGELOG entry.
-->
- [ ] I have run `make changelog` and committed the
`changelog/pending/<file>` documenting my change
<!--
If the change(s) in this PR is a modification of an existing call to the
Pulumi Cloud,
then the service should honor older versions of the CLI where this
change would not exist.
You must then bump the API version in
/pkg/backend/httpstate/client/api.go, as well as add
it to the service.
-->
- [ ] Yes, there are changes in this PR that warrants bumping the Pulumi
Cloud API version
<!-- @Pulumi employees: If yes, you must submit corresponding changes in
the service repo. -->
2024-05-20 17:00:16 +00:00
..
testdata GenerateHCL2Definition should respect logical names (#14639) 2023-11-22 17:43:30 +00:00
hcl2.go [engine/import] Guess ID references of dependant resources when generating code for import operations (#16208) 2024-05-20 17:00:16 +00:00
hcl2_test.go [engine/import] Guess ID references of dependant resources when generating code for import operations (#16208) 2024-05-20 17:00:16 +00:00
language.go [engine/import] Guess ID references of dependant resources when generating code for import operations (#16208) 2024-05-20 17:00:16 +00:00
language_test.go Lift context parameter to SerializeDeployment/Resource/Operations/Properties (#15929) 2024-04-15 07:45:46 +00:00