pulumi/sdk/go/common/resource/config
Thomas Gummerer c7df3d2513
tighten up parsing of property path to avoid accepting typos (#14257)
The key "my:root.[1]" used to not be accepted, because the `.` before
the index is invalid. However through
https://github.com/pulumi/pulumi/pull/13814/files#r1320306140 and
subsequently https://github.com/pulumi/pulumi/pull/14149, the parsing
was loosened.

Presumably we were never checking this at the right level in the first
place, and we only accidentally refused to parse it. Fix this by
tightening the conditions when parsing the property path.

## Checklist

- [x] I have run `make tidy` to update any new dependencies
- [x] I have run `make lint` to verify my code passes the lint check
  - [ ] I have formatted my code using `gofumpt`

<!--- Please provide details if the checkbox below is to be left
unchecked. -->
- [x] I have added tests that prove my fix is effective or that my
feature works
<!--- 
User-facing changes require a CHANGELOG entry.
-->
- [ ] I have run `make changelog` and committed the
`changelog/pending/<file>` documenting my change
<!--
If the change(s) in this PR is a modification of an existing call to the
Pulumi Cloud,
then the service should honor older versions of the CLI where this
change would not exist.
You must then bump the API version in
/pkg/backend/httpstate/client/api.go, as well as add
it to the service.
-->
- [ ] Yes, there are changes in this PR that warrants bumping the Pulumi
Cloud API version
<!-- @Pulumi employees: If yes, you must submit corresponding changes in
the service repo. -->
2023-10-17 07:20:28 +00:00
..
testdata/repr [config] Clean up implementation (#13814) 2023-10-09 04:51:21 +00:00
crypt.go [config] Clean up implementation (#13814) 2023-10-09 04:51:21 +00:00
key.go Cleaning up a few pkg/errors uses 2022-11-02 14:20:44 +00:00
key_test.go all: Reformat with gofumpt 2023-03-03 09:00:24 -08:00
map.go [config] Clean up implementation (#13814) 2023-10-09 04:51:21 +00:00
map_test.go tighten up parsing of property path to avoid accepting typos (#14257) 2023-10-17 07:20:28 +00:00
object.go ignore unexpected types instead of erroring out (#14149) 2023-10-11 16:39:16 +00:00
plaintext.go [config] Clean up implementation (#13814) 2023-10-09 04:51:21 +00:00
plaintext_test.go [config] Clean up implementation (#13814) 2023-10-09 04:51:21 +00:00
repr_test.go [config] Clean up implementation (#13814) 2023-10-09 04:51:21 +00:00
value.go [cli] Add support for environments (#14140) 2023-10-10 01:35:39 +00:00
value_test.go [config] Clean up implementation (#13814) 2023-10-09 04:51:21 +00:00