mirror of https://github.com/pulumi/pulumi.git
1260aafd50
12795: Enable Rome Linter And Add One Lint r=RobbieMcKinstry a=RobbieMcKinstry <!--- Thanks so much for your contribution! If this is your first time contributing, please ensure that you have read the [CONTRIBUTING](https://github.com/pulumi/pulumi/blob/master/CONTRIBUTING.md) documentation. --> # Description <!--- Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. --> Currently, we employ Rome as a formatter for the Node SDK. This PR enables the Rome Linter. It disables all lints by default and opts-in to a single lint: `nodelete`. The delete operator harms performance and can cause unexpected behavior; most often, assigning `undefined` is preferred to using `delete`. [See the documentation for details.](https://docs.rome.tools/lint/rules/nodelete/) In this PR, I had to update our closure serialization tests to satisfy the test suite. ## Checklist **N/A:** This change is a refactor only. <!--- Please provide details if the checkbox below is to be left unchecked. --> - [ ] I have added tests that prove my fix is effective or that my feature works <!--- User-facing changes require a CHANGELOG entry. --> - [ ] I have run `make changelog` and committed the `changelog/pending/<file>` documenting my change <!-- If the change(s) in this PR is a modification of an existing call to the Pulumi Cloud, then the service should honor older versions of the CLI where this change would not exist. You must then bump the API version in /pkg/backend/httpstate/client/api.go, as well as add it to the service. --> - [ ] Yes, there are changes in this PR that warrants bumping the Pulumi Cloud API version <!-- `@Pulumi` employees: If yes, you must submit corresponding changes in the service repo. --> Co-authored-by: Robbie McKinstry <robbie@pulumi.com> |
||
|---|---|---|
| .. | ||
| go | ||
| nodejs | ||
| proto/go | ||
| python | ||
| README.md | ||
| go.mod | ||
| go.sum | ||