pulumi/sdk/nodejs
bors[bot] 1260aafd50
Merge #12795
12795: Enable Rome Linter And Add One Lint r=RobbieMcKinstry a=RobbieMcKinstry

<!--- 
Thanks so much for your contribution! If this is your first time contributing, please ensure that you have read the [CONTRIBUTING](https://github.com/pulumi/pulumi/blob/master/CONTRIBUTING.md) documentation.
-->

# Description

<!--- Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. -->

Currently, we employ Rome as a formatter for the Node SDK. This PR enables the Rome Linter. It disables all lints by default and opts-in to a single lint: `nodelete`.

The delete operator harms performance and can cause unexpected behavior; most often, assigning `undefined` is preferred to using `delete`. [See the documentation for details.](https://docs.rome.tools/lint/rules/nodelete/)

In this PR, I had to update our closure serialization tests to satisfy the test suite.

## Checklist

**N/A:** This change is a refactor only.

<!--- Please provide details if the checkbox below is to be left unchecked. -->
- [ ] I have added tests that prove my fix is effective or that my feature works
<!--- 
User-facing changes require a CHANGELOG entry.
-->
- [ ] I have run `make changelog` and committed the `changelog/pending/<file>` documenting my change
<!--
If the change(s) in this PR is a modification of an existing call to the Pulumi Cloud,
then the service should honor older versions of the CLI where this change would not exist.
You must then bump the API version in /pkg/backend/httpstate/client/api.go, as well as add
it to the service.
-->
- [ ] Yes, there are changes in this PR that warrants bumping the Pulumi Cloud API version
  <!-- `@Pulumi` employees: If yes, you must submit corresponding changes in the service repo. -->


Co-authored-by: Robbie McKinstry <robbie@pulumi.com>
2023-05-09 22:00:47 +00:00
..
asset Apply autoformat 2023-04-28 18:27:10 -04:00
automation Apply autoformat 2023-04-28 18:27:10 -04:00
cmd Apply autoformat 2023-04-28 18:27:10 -04:00
dist Fix typo in PP script 2019-08-06 17:35:52 -07:00
dynamic Apply autoformat 2023-04-28 18:27:10 -04:00
iterable Apply autoformat 2023-04-28 18:27:10 -04:00
log Apply autoformat 2023-04-28 18:27:10 -04:00
npm all: Reformat with gofumpt 2023-03-03 09:00:24 -08:00
proto gRPC for GenerateProject/Program/Package 2023-05-06 13:14:59 +01:00
provider Apply autoformat 2023-04-28 18:27:10 -04:00
queryable Apply autoformat 2023-04-28 18:27:10 -04:00
runtime Don't use the `delete` operator. 2023-04-28 22:07:35 -04:00
tests Fix closure serialization test cases. 2023-05-09 14:50:28 -04:00
tests_with_mocks Apply autoformat 2023-04-28 18:27:10 -04:00
.eslintrc.js Apply autoformat 2023-04-28 18:27:10 -04:00
.gitignore ci: Pin yarn lockfile for security & dependency scanning 2022-09-21 15:35:43 -07:00
Makefile Add Rome autoformatter to Node SDK. 2023-04-28 18:25:36 -04:00
README.md adjust link text in node sdk readme (#8816) 2022-01-28 16:45:55 -08:00
config.ts Apply autoformat 2023-04-28 18:27:10 -04:00
errors.ts Use ESlint instead of TSlint (#7719) 2021-08-10 11:31:59 -07:00
index.ts Removing x namespace from go/python/nodejs automation packages (#6518) 2021-04-14 19:32:18 +01:00
invoke.ts [sdk/nodejs] Add pluginServerURL (#8698) 2022-01-10 15:54:41 -08:00
metadata.ts Make getOrganization total, default to 'organization' 2022-09-22 11:06:51 -07:00
output.ts Apply autoformat 2023-04-28 18:27:10 -04:00
package.json Add Rome autoformatter to Node SDK. 2023-04-28 18:25:36 -04:00
resource.ts Don't use the `delete` operator. 2023-04-28 22:07:35 -04:00
rome.json Don't use the `delete` operator. 2023-04-28 22:07:35 -04:00
stackReference.ts Apply autoformat 2023-04-28 18:27:10 -04:00
tsconfig.json sdk/node/StackReference: Add getOutputDetails 2023-02-03 16:47:27 -08:00
tsutils.ts [sdk/nodejs] Mark internal APIs `@internal` to filter from SDK docs 2022-09-20 11:54:06 -07:00
utils.ts Apply autoformat 2023-04-28 18:27:10 -04:00
version.ts Add license headers 2018-05-22 15:02:47 -07:00
yarn.lock Add Rome autoformatter to Node SDK. 2023-04-28 18:25:36 -04:00

README.md

Pulumi Node.js SDK

The Pulumi Node.js SDK lets you write cloud programs in JavaScript.

Installation

Using npm:

$ npm install --save @pulumi/pulumi

Using yarn:

$ yarn add @pulumi/pulumi

This SDK is meant for use with the Pulumi CLI. Visit Pulumi's Download & Install to install the CLI.

Building and Testing

For anybody who wants to build from source, here is how you do it.

Prerequisites

This SDK uses Node.js and we support any of the Current, Active and Maintenance LTS versions. We support both NPM and Yarn for package management.

At the moment, we only support building on macOS and Linux, where standard GNU tools like make are available.

Make Targets

To build the SDK, simply run make from the root directory (where this README lives, at sdk/nodejs/ from the repo's root). This will build the code, run tests, and install the package and its supporting artifacts.

At the moment, for local development, we install everything into $HOME/.dev-pulumi. You will want this on your $PATH.

The tests will verify that everything works, but feel free to try running pulumi preview and/or pulumi up from the examples/minimal/ directory. Remember to run tsc first, since pulumi expects JavaScript, not TypeScript.